search

rubymem / bundler-leak

Known-leaky gems verification for bundler: `bundle leak` to check your app and find leaky gems in your Gemfile :gem::droplet:
https://www.rubymem.com
GNU General Public License v3.0
288 stars 11 forks source link

Ignore option #18

Closed andyw8 closed 4 years ago

andyw8 commented 5 years ago

It would be useful to have an --ignore option similar to what bundler-audit has.

bronzdoc commented 5 years ago

Hey @andyw8 thanks for the suggestion! could you elaborate how such option would work for bundler-leak? what would be a nice use case for a flag like that? thanks!

andyw8 commented 5 years ago

Sure: I want to use this as part of a CI build. The legacy app I'm working on has some gems with known leaks. I do plan to fix upgrade those, but not immediately. I want to use bundler-leak to detect any new problems, and fail the build if any are found.

bronzdoc commented 5 years ago

@andyw8 cool.

What should we pass to the --ignore flag?

andyw8 commented 5 years ago

How about {gemname}-{issue number}?

e.g. for https://github.com/rubymem/ruby-mem-advisory-db/blob/master/gems/celluloid/670.yml it would be celluloid-670.

bronzdoc commented 5 years ago

@andyw8 Sounds reasonable 👍