bradgessler
commented
2 months ago Thanks for the PR! Could you alias :template :view_template in Superform::Field for backwards compatibility with Phlex 1.x?
Open joostvanrijn opened 2 months ago
bradgessler
commented
2 months ago Thanks for the PR! Could you alias :template :view_template in Superform::Field for backwards compatibility with Phlex 1.x?
joostvanrijn
commented
2 months ago Sure can! Should I then also revert the change in the gemspec? So we'll depend op ~> 1.0 instead of ~> 1.2?
bradgessler
commented
2 months ago Yeah, you can relax that gemspec too. I'm going to keep them compatible with each other as long as possible. Maybe in 1.x I'll make the breaking change that drops template.
joostvanrijn
commented
2 months ago Alright. This should do it then.
joostvanrijn
commented
1 month ago @bradgessler does this PR still require work on my side?
bradgessler
commented
1 month ago Nope! Just waiting as long as I can before merging this since Phlex 2.x isn't out and Phlex isn't pushing the change too hard (docs on the website still say def template at https://www.phlex.fun/ ... which maybe I could get changed?)
Phlex 2.0 will rename the template methods to view_template and
def templatewill render a tag.Fixes #35