search

rubymonsters / fiftypercent

50 percent, that's half of it. Women make up roughly half of the world's population. But they rarely make up half the participant on discussion panels, on the microphone, in talk show or conferences. "50 Prozent" documents, how many women* there are.
https://50prozent.speakerinnen.org/en/
9 stars 2 forks source link

Header design does not work on production #43

Closed tyranja closed 5 years ago

tyranja commented 5 years ago

The new header design works fine locally but the responsive menu does not work properly on production :(

Local: Screenshot from 2019-08-12 22-17-04

production: Screenshot from 2019-08-12 22-17-12

Do you have any ideas? @alicetragedy @jancborchardt

I only deployed the first PR yet.

tyranja commented 5 years ago

Hm, I might have to precompile the assets on the production serve. But when I try, the server wants me to install yarn first and I don't have the sudo password. Looks like I need on more day for that to fix. :( I was so looking forward to the new design.

I did a rollback on production so it does not look broken. Is that ok?

jancborchardt commented 5 years ago

I did a rollback on production so it does not look broken. Is that ok?

Yeah, absolutely no problem! :) @alicetragedy and I were also wondering how often stuff is deployed – so it’s done manually? There’s no rush on our side, and we work on several things in parallel.

alicetragedy commented 5 years ago

+1 on what @jancborchardt wrote, there’s no rush on our side and we’d also be happy to do PRs against a staging branch if you want to try stuff on a staging environment first (but I don’t know if you think it’s worth setting something like that up for 50 percent). It would give us the possibility to try things out in a production-like environment and to work with small improvements but I think it’s really up to you!

tyranja commented 5 years ago

Yeah, deployment is done manually. I do it :grin: and yes @alicetragedy I planned to build a staging server. no time yet. I hope to do once the :baby: is in the kita.

The server ruby version is updated to 2.6.3 so I will update the version in fiftypercent.

tyranja commented 5 years ago

So, now I know the problem. The links in the header in production link to pages that do not exist locally. So my seeding was incorrect :(

Screenshot from 2019-08-14 12-06-58

Production looks now like that at the moment. I have to adjust the seeds in the code to add the imprint and stuff.

tyranja commented 5 years ago

@alicetragedy and @jancborchardt

So i have added more to the seeds for the sidebar and static pages: https://github.com/rubymonsters/fiftypercent/pull/44/files

So you can drop and setup the database and then you can see locally what is wrong in production. :sweat_smile: That took me a while to figure out why it was different locally and on production.

I commented the code out https://github.com/rubymonsters/fiftypercent/blob/master/app/views/shared/_header.html.erb#L36 and deployed so the strange looking links are not there any more.

jancborchardt commented 5 years ago

I commented the code out https://github.com/rubymonsters/fiftypercent/blob/master/app/views/shared/_header.html.erb#L36 and deployed so the strange looking links are not there any more.

Aaah right, good catch! When @alicetragedy and I talked about the design we decided that basically all of those items can go into the "About" page, so as soon as I’m done with that I will also remove those commented parts. :)