search

rubymotion-community / BubbleWrap

Cocoa wrappers and helpers for RubyMotion (Ruby for iOS and OS X) - Making Cocoa APIs more Ruby like, one API at a time. Fork away and send your pull requests
Other
1.18k stars 208 forks source link

RubyMotion 2.4 Breaks Specs #274

Closed clayallsopp closed 10 years ago

clayallsopp commented 11 years ago

from #272:

it seems the fix to RM-3 has broken this test: https://github.com/rubymotion/BubbleWrap/blob/master/spec/motion/core/ns_notification_center_spec.rb#L18

the notified object outside of the callback is different than the notified inside - you can verify this by logging the notified.object_id: https://gist.github.com/clayallsopp/5995437

If you make notified an @ivar, it passes, but I'd say this is an unexpected RubyMotion regression. I've filed a ticket with HipByte.

HipByte issue: http://hipbyte.myjetbrains.com/youtrack/issue/RM-215

jimsynz commented 11 years ago

Thanks @clayallsopp can you link the HipByte ticket also?

jimsynz commented 11 years ago

Also, once this is fixed, do you guys want to do a release?

clayallsopp commented 11 years ago

:+1:

jimsynz commented 11 years ago

1.3.1 or 1.4.0?

clayallsopp commented 11 years ago

Hmmm, looking at the diff, I think the correct semver thing to do is 1.4? ("add functionality in a backwards-compatible manner" vs. "make backwards-compatible bug fixes")

jimsynz commented 11 years ago

Is there any changed API, or just new API? Cursory glance seems to indicate just new API.

clayallsopp commented 11 years ago

Yup, all new APIs, nothing that breaks backwards compat. (sanity check == specs that have red in diffs)

Only iffy thing I can see is an option was removed from BW::Reactor::PeriodicTimer 07b45e3e854716c7bc48b435468a6bb209306118 279776c12f0e636a03ff91e9fcb575b8ec772594 6810eda26a743435d02fe1504b126199b29807c9

jimsynz commented 11 years ago

Yeah. No more common runloop modes bollocks in Timer.