search

rubymotion-community / BubbleWrap

Cocoa wrappers and helpers for RubyMotion (Ruby for iOS and OS X) - Making Cocoa APIs more Ruby like, one API at a time. Fork away and send your pull requests
Other
1.18k stars 208 forks source link

Added convenience method App#can_open_url and enhanced description for App#open_url #360

Closed MarkVillacampa closed 10 years ago

MarkVillacampa commented 10 years ago

Not a big thing but since App#open_url is there, having App#can_open_url is nice.

Also enhanced the documentation to reflect that it can not only handle http urls but any custom schemas as well.

PS: git removed the text between "``" so the commit message is wrong, sorry about that.

markrickert commented 10 years ago

Looks like the tests are failing here on the NetworkIndicator stuff that @colinta implemented. Could it be that this spec file: https://github.com/rubymotion/BubbleWrap/blob/master/spec/motion/network-indicator/network_indicator_spec.rb isn't wrapped in App.ios??

clayallsopp commented 10 years ago

Hm, it looks like they're failing on the known memory problems with BW::Reactor? (see #359). This is what the travis output looks like to me:

Bacon::Error: false.==(true) failed
    spec.rb:700:in `satisfy:': memory implications - does not cause a retain-cycle after adding an event
    spec.rb:714:in `method_missing:'
    spec.rb:440:in `execute_block'
    spec.rb:404:in `run_postponed_block:'
830 specifications (1234 requirements), 1 failures, 0 errors
clayallsopp commented 10 years ago

@MarkVillacampa would be cool to add a line about the new method in the README list of App methods w/ this PR

MarkVillacampa commented 10 years ago

@markrickert @clayallsopp +1, It looks like it's the Eventable spec what is failing. This is expected to be solved by the next version of RM.

@clayallsopp done!

clayallsopp commented 10 years ago

Groovy, thanks!