Remove strongly held target from kvo targets hash

rubymotion-community / BubbleWrap

Cocoa wrappers and helpers for RubyMotion (Ruby for iOS and OS X) - Making Cocoa APIs more Ruby like, one API at a time. Fork away and send your pull requests

Other

1.18k stars 208 forks source link

Remove strongly held target from kvo targets hash #397

Closed jsteinberg closed 10 years ago

jsteinberg commented 10 years ago

This issue seems to also be resolved in this PR(https://github.com/rubymotion/BubbleWrap/pull/361), but has not been merged in yet. This PR resolves only the issue I ran into. Keeping a strong reference in @targets is okay, as long as it is removed when no longer needed. The way it currently is, the target object will only be released when the observing object is also released(releasing @targets)

jsteinberg commented 10 years ago

Didn't realize doing a PR off of master would add my new commits. I will re-add off of a branch with isolated commit.