search

rubymotion-community / motion-support

Commonly useful extensions to the standard library for RubyMotion
MIT License
132 stars 28 forks source link

Delegate all Hash methods to NSDictionary #16

Closed kareemk closed 10 years ago

kareemk commented 10 years ago

This is especially important with the deep methods as they are recursive

tkadauke commented 10 years ago

Hey Kareem,

Thanks for this pull request. However, there is a reason why not all the additions to hash are in NSDictionary, which is that they might break things in an unforeseen manner. This is why there is a spec file ns_dictionary_spec.rb in the source tree, that contains extra tests adapted for additions to NSDictionary. Can you 1) only add stuff that is absolutely essential to NSDictionary and 2) add thorough tests for every method?

Thanks! --Thomas

tkadauke commented 10 years ago

Nice one!

tkadauke commented 10 years ago

Damn it, Github screwed me over. Meant to merge #21 :(