search

rubymotion-community / motion-support

Commonly useful extensions to the standard library for RubyMotion
MIT License
132 stars 28 forks source link

Fix existing specs #29

Closed jbender closed 8 years ago

jbender commented 8 years ago

Several specs fail out of the box, this fixes either the relevant spec or code that wasn't passing.

jbender commented 8 years ago

Ping @colinta or @tkadauke for a second pair of eyes before merging it

jbender commented 8 years ago

@colinta @tkadauke Any closing thoughts here and/or reason not to merge?

colinta commented 8 years ago

One reason I'm not eager to merge is that there are lots of "style changes", that are purely cosmetic. This is unnecessary noise, I'd like to see this undone before merging. It makes it hard for someone to evaluate the PR quickly.

tkadauke commented 8 years ago

^^ I agree with @colinta. Remove the linter changes to comments and indentation, then we'll merge it.

jbender commented 8 years ago

@colinta @tkadauke finally got 'round to rebasing this, should be good to go

colinta commented 8 years ago

@jbender Thanks for doing that! This looks good to me, gonna go ahead and merge and cut a new version.