search

rubymotion-community / motion-support

Commonly useful extensions to the standard library for RubyMotion
MIT License
132 stars 28 forks source link

Add Rubocop style checks #31

Closed jbender closed 8 years ago

jbender commented 8 years ago

Ideally all of the gem's code should appear as though it were written by the same person, which makes it easier to understand what's going on by knowing the established conventions.

This PR does not perform style checks on the specs directory, which will take additional work.

tkadauke commented 8 years ago

I don't know if that is a good idea. I didn't apply styling changes to the code so that patches could be applied more easily between the original source (from rails/rails/activesupport). Linting the shit out of the source code makes it pretty, but it also breaks applying patches.

jbender commented 8 years ago

I think that there's already enough of a (necessary) departure from the rails/activesupport project that simply copy/pasting code into this one won't work perfectly and people will have to customize it anyway. I'd argue that the linting make it easier to know what's expected for project contributions moving forward (e.g. https://github.com/rubymotion/motion-support/pull/29#discussion_r44864814).