Remove motion-require. - Githubissues

rubymotion-community / motion-support

Commonly useful extensions to the standard library for RubyMotion

MIT License

132 stars 28 forks source link

Remove motion-require. #40

Closed wndxlori closed 6 years ago

wndxlori commented 6 years ago

This is a 🤞 final fix for Issue 38, which will make motion-support work properly on High Sierra.

Main feature: rips motion-require out by the roots, and manages class loading/compilation order to 1) make it all work and 2) remove cyclical dependencies.

Minor updates:

update Rakefile for current RubyMotion
fix a couple types
fix a build error
adds a spec for plus_with_duration (+), which would have broken with the previous "fixes" that just commented out the broken bits.

colinta commented 6 years ago

That's awesome, @wndxlori thank you! Glad to see checks passing again, too!

wndxlori commented 6 years ago

I guess we should bump the version number and get this released, too? Do you want a PR for that, or can you just get that done? I'm thinking at least a 1.2?

colinta commented 6 years ago

Done! https://rubygems.org/gems/motion-support/versions/1.2.0 👍