Closed ndorfin closed 7 years ago
I'll pass this one on to the Icelab team, using metaquery is their call - all seems reasonable to me but I'm not familiar with the benefits of using metaquery in the first place - @timriley @libbyberrie @tobydallder
I reckon if the same responsive layout changes have been achieved without metaquery, this is all good!
@raquelxmoss wrote the nav js - can you review the changes to that
Do you know a good casual image diff service? Since this changes the way responsive stuff is done, it'd be good to test it pretty thoroughly, but it can be tough to spot subtle problems when doing that manually. I've found percy.io pretty good but doesn't really work for this kind of thing - don't really want to set anything up permanently for this repo
Can you put some screenshots up? Changes if there's anything that's actually changed, or before/after if nothing should have changed - in particular the hamburger icon and the changes to the responsive styles
@mermop Will do - thanks! I'll find a nice SVG replacement for the Menu Icon, and then take some before and after screenies.
Before | After |
---|---|
Before | After |
---|---|
Thanks for those! Only difference I can see is that the "menu" link is pink now for some reason?
@mermop Yup, I can happily swap it back to the grey. Made it red so that it matches other links - not sure why it was grey to begin with.
Let's go back to grey for it please :)
@mermop Done :)
Couple of conflicts from merging #29 - will aim to do some testing of this this weekend
@mermop Conflicts resolved
Noting that these changes make the mobile menu opening and closing animations less nice:
I'll start breaking this up into smaller PRs.
In this PR:
@media
blocks.Other possible improvements could include using 1
<nav>
rather than 2 for the main menu.