Jets::Commands::Db::Tasks.load! causes problems when using Dynamoid

Checklist

[x] Upgrade Jets: Are you using the latest version of Jets? This allows Jets to fix issues fast. There's a jets upgrade command that makes this a simple task. There's also an Upgrading Guide: http://rubyonjets.com/docs/upgrading/
[x] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.rubyonjets.com
[x] Code sample: Have you put together a code sample to reproduce the issue and make it available? Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software	Version
Operating System	Ubuntu 18.04
Jets	2.3.12
Ruby	2.5.6

Expected Behaviour

I can create a table with Dynamoid using rake dynamoid:create_tables and Jets doesn't interfere with the rake task.

Current Behavior

While loading Jets tasks, Jets::Commands::Db::Tasks.load! loads ActiveRecord db tasks which sets a dummy Rails.application
This confuses Rails and causes the following warning: Rails couldn't infer whether you are using multiple databases from your database.yml and can't generate the tasks for the non-primary databases. If you'd like to use this feature, please simplify your ERB.
This confuses Dynamoid into thinking that the app's name is Jets::Commands::Db::Tasks::Dummy and trying to create a table name with that value

Rails couldn't infer whether you are using multiple databases from your database.yml and can't generate the tasks for the non-primary databases. If you'd like to use this feature, please simplify your ERB. D, [2020-02-19T18:31:26.923510 #13842] DEBUG -- : list_tables | Request "{}" | Response "{\"TableNames\":[]}" D, [2020-02-19T18:31:26.923668 #13842] DEBUG -- : (5.47 ms) LIST TABLES D, [2020-02-19T18:31:26.933931 #13842] DEBUG -- : list_tables | Request "{}" | Response "{\"TableNames\":[]}" D, [2020-02-19T18:31:26.934115 #13842] DEBUG -- : (10.27 ms) LIST TABLES D, [2020-02-19T18:31:26.934167 #13842] DEBUG -- : (10.34 ms) CACHE TABLES I, [2020-02-19T18:31:26.934247 #13842] INFO -- : Creating dynamoid_Jets::Commands::Db::Tasks::Dummy_development_users table. This could take a while. D, [2020-02-19T18:31:26.971592 #13842] DEBUG -- : create_table | Request "{\"TableName\":\"dynamoid_Jets::Commands::Db::Tasks::Dummy_development_users\",\"KeySchema\":[{\"AttributeName\":\"id\",\"KeyType\":\"HASH\"}],\"AttributeDefinitions\":[{\"AttributeName\":\"id\",\"AttributeType\":\"S\"}],\"BillingMode\":\"PROVISIONED\",\"ProvisionedThroughput\":{\"ReadCapacityUnits\":100,\"WriteCapacityUnits\":20}}" | Response "{\"__type\":\"com.amazon.coral.validate#ValidationException\",\"message\":\"Invalid table/index name. Table/index names must be between 3 and 255 characters long, and may contain only the characters a-z, A-Z, 0-9, '_', '-', and '.'\"}" rake aborted! Aws::DynamoDB::Errors::ValidationException: Invalid table/index name. Table/index names must be between 3 and 255 characters long, and may contain only the characters a-z, A-Z, 0-9, '_', '-', and '.'

Step-by-step reproduction instructions

Initialize Jets project and add the Dynamoid gem
Define a Dynamoid model
Run rake dynamoid:create_tables to create DynamoDB tables

Code Sample

class User
  include Dynamoid::Document

end

Solution Suggestion

Add a Jets config option to disable_active_record (or something more elegant), should conditionally call Jets::Commands::Db::Tasks.load! in Jets::Commands::RakeTasks, like we do for loading webpack tasks
Move load File.expand_path("../environment-task.rake", __FILE__) from Jets::Commands::Db::Tasks.load and put it in Jets::Commands::RakeTasks instead

# lib/jets/commands/rake_tasks.rb

    def load!
      return if @@loaded # prevent loading twice
      # Run Bundler.setup so all project rake tasks also show up in `jets help`
      Jets::Bundle.setup

-     Jets::Commands::Db::Tasks.load!
+     Jets::Commands::Db::Tasks.load! unless Jets.config.active_record_disabled?
+     load File.expand_path("../environment-task.rake", __FILE__)
      load_webpacker_tasks

      # custom project rake tasks
      Dir.glob("#{Jets.root}/lib/tasks/*.rake").each { |r| load r }

      @@loaded = true
    end

My monkeypatch fix, for reference

# Rakefile

require 'jets'
# HACK: Avoid loading ActiveRecord tasks
class Jets::Commands::Db::Tasks
  def self.load!
    Rake::Task.define_task(:environment) { Jets.boot }
  end
end
Jets.load_tasks
require 'dynamoid/tasks'

rubyonjets / jets