rubyonjets / jets

Ruby on Jets
http://rubyonjets.com
MIT License
2.6k stars 181 forks source link

Jets does not support multiple value response headers #555

Closed SteffanPerry closed 3 years ago

SteffanPerry commented 3 years ago

Checklist

My Environment

Software Version
Operating System OSX 10.15.7
Jets 3.0.5
Ruby 2.7.2

Expected Behaviour

Setting response headers with multiple values should create a seperate response header for each value.

Current Behavior

Currently, settings a header to multiple values results in a single response header containing all values.

Step-by-step reproduction instructions

Create a multi-value header and deploy to staging.

Note: This issue does not occur locally using puma

set_header('Set-Cookie', ['cookie_a=a', 'cookie_b=b'])

Solution Suggestion

Use API gateways"multiValueHeaders" field when rendering a response.

SteffanPerry commented 3 years ago

I will have a PR for this issue shortly.

tongueroo commented 3 years ago

Fixed in #556