rubyonjets / jets

Ruby on Jets
http://rubyonjets.com
MIT License
2.6k stars 181 forks source link

fixes for dotenv 3.1 #718

Closed tongueroo closed 7 months ago

tongueroo commented 7 months ago

This is a 🐞 bug fix.

Summary

Fixes for Dotenv 3.0. Dotenv 3.0 made some breaking changes in order to make some good improvements. See it's changelog: https://github.com/bkeepers/dotenv/blob/main/Changelog.md

Users have reported this and have been able to workaround it by pinning dotenv to 2 See #712

Also, there's a related PR #716 Totally get taking the approach to pin to lower versions. I've done it myself when there's a time-crunch.

This PR upgrades Jets so it works with the newer Dotenv 3.0 version and requires it. This will mean that users who have already pinned dotenv 2 in their Gemfile, will need to remove it.

Eventually, found that older versions of gems become vaporware. Maintainers have other things in life than trying to keep old versions working 🤣

Some notes/thoughts about gem version pinning:

Some notes about dotenv 3.0 behavior:

Context

Closes #712 #716

How to Test

Create and deploy a Jets demo app.

Version Changes

Patch