Use Nokogiri with line numbers

rubys / nokogumbo

A Nokogiri interface to the Gumbo HTML5 parser.

Apache License 2.0

186 stars 114 forks source link

Use Nokogiri with line numbers #130

Closed fulldecent closed 3 years ago

fulldecent commented 5 years ago

This allows to use the PR at https://github.com/sparklemotion/nokogiri/pull/1918 today.

Then development effort can continue using line numbers. This is a path forward to allow html-proofer to work with HTML5.

Recommending that this PR be updated to merge into a new branch here, rather than master.

fulldecent commented 5 years ago

Ready for review.

stevecheckoway commented 5 years ago

Oh, a new branch here. Hmm. I'm not sure I have an informed opinion on that.

fulldecent commented 5 years ago

This issue (downstream) has been open for three years, so having a new branch here (which does not need to be maintained) is just some progress forward.

sunny commented 4 years ago

This has be included in nokogiri v1.11.0.rc1 🎉

flavorjones commented 3 years ago

As noted by @sunny above, Nokogiri v1.11.0 and later support Node#line=, so I'm going to close this without merging.