search

rubys / nokogumbo

A Nokogiri interface to the Gumbo HTML5 parser.
Apache License 2.0
186 stars 114 forks source link

Ruby 2.7.0 warnings #134

Closed ghost closed 4 years ago

ghost commented 4 years ago

nokogumbo-2.0.2/lib/nokogumbo/html5.rb:74: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

nokogumbo-2.0.2/lib/nokogumbo/html5.rb:21: warning: The called method `parse' is defined here

nokogumbo/html5.rb:22: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

nokogumbo/html5/document.rb:4: warning: The called method `parse' is defined here

stevecheckoway commented 4 years ago

Thanks. I haven't tried using 2.7 yet.

As I recall, this was either to match Nokogiri's API or to work around a limitation of older versions of Ruby (or both).

ghost commented 4 years ago

This change is documented in the 2.7 release notes:

https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/

stevecheckoway commented 4 years ago

Ah, I misunderstood what the issue was. Thanks.

MatzFan commented 4 years ago

Is there any chance of another release which incorporates this fix for the Ruby 2.7 warning? Many thanks for the great gem.

stevecheckoway commented 4 years ago

Sure, but I'm swamped until the weekend at least.