Can't install with nokogiri 1.11.0.rc3

rubys / nokogumbo

A Nokogiri interface to the Gumbo HTML5 parser.

Apache License 2.0

186 stars 114 forks source link

Closed casperisfine closed 4 years ago

casperisfine commented 4 years ago

Nokogiri is working on shipping with precompiled binaries, if one of these precompiled nokogiri is installed it cause nokogumbo to fail:

 extconf.rb:67:in `join': no implicit conversion of nil into String (TypeError)
        from extconf.rb:67:in `<main>'
extconf failed, exit code 1

flavorjones commented 4 years ago

@casperisfine - thanks for opening this. This is a known issue - https://github.com/sparklemotion/nokogiri/pull/1788 - should be fixed for the next nokogiri v1.11.0 release candidate.

(I think this issue should be closed, because I think the bug is with Nokogiri breaking an implicit contract with Nokogumbo.)

casperisfine commented 4 years ago

👌