ci: add Ruby 3 to Github Actions and Appveyor

rubys / nokogumbo

A Nokogiri interface to the Gumbo HTML5 parser.

Apache License 2.0

186 stars 114 forks source link

ci: add Ruby 3 to Github Actions and Appveyor #167

Closed flavorjones closed 3 years ago

flavorjones commented 3 years ago

remove pre-2.5 from Appveyor
drop travis entirely

Supersedes #139

flavorjones commented 3 years ago

@stevecheckoway @rubys How do y'all feel about me removing travis in this commit? I'm confident that the current Github Actions entirely reproduce, and are faster than, the Travis config.

stevecheckoway commented 3 years ago

Thank you for doing this! I originally asked @rubys to add Appveyor because Travis didn't support Windows. Now that GitHub Actions supports Windows, is there any reason to keep Appveyor? It seems to be much slower.

flavorjones commented 3 years ago

@stevecheckoway That's a good question, and I think the answer is probably "No." I'll probably put removal of appveyor in a separate PR just to make sure we get a solid "green" across both GA and Appveyor, which we haven't had.