rubys / venus

Planet Venus is an awesome ‘river of news’ feed reader. It downloads news feeds published by web sites and aggregates their content together into a single combined feed, latest news first.
http://intertwingly.net/code/venus/docs/index.html
Other
274 stars 99 forks source link

Adjust sanitization code to allow HTML5 'data-' attributes through. #19

Open nathan-osman opened 12 years ago

nathan-osman commented 12 years ago

Basically I have made two minor modifications to files in the planet/vendor folder.

Both planet/vendor/feedparser.py and planet/vendor/html5lib/sanitizer.py (which are used for sanitizing the HTML / XHTML encountered in a feed) strip out HTML5 data attributes. These attributes have no meaning to the browser (they are ignored) but third party scripts that are added to the planet page may make use of these attributes and having them stripped out breaks the scripts (or causes them to fail).

Therefore, I have modified the two above files to allow these attributes to pass through the filtering / sanitization unaltered.

Please let me know if you have any questions / concerns.