Planet Venus is an awesome ‘river of news’ feed reader. It downloads news feeds published by web sites and aggregates their content together into a single combined feed, latest news first.
At the risk of pushing too large of a pull request here is a quick cleanup of the tests in this module. I have focused on PEP8 but also ripped out code for Python 2.2 and updated code for 2.7. The eventual goal (for me) is getting this running on Python 2.7 and Python 3.4+. This is not Python3 compatible at the moment and won't be until I dive deeper into the core.
Some key things:
Renamed things that were shadowing builtins.
Made Exception catching more specific
Lots of whitespace fixes
Added file encoding headers
Add file context managers instead of manual .open() .close()
Modern print statements (including from __future__ import print_function
.has_key() has been depreciated. now using the in keyword
Modern Exception statements (i.e. raise RuntimeError, "can't parse %s" % name -> raise RuntimeError("can't parse %s" % name)
All the tests pass on my machine with the exception of Django and RDF which have both changed significantly since this package was last updated.
Notes:
I had to do some shenanigans to get dbhash to run on my macOS machine but those tests pass.
macOS's sed doesn't have a --version flag. Or even a version number which is super bizarre. Those tests pass when they are forced to run.
Cabalist
commented
7 years ago
At the risk of pushing too large of a pull request here is a quick cleanup of the tests in this module. I have focused on PEP8 but also ripped out code for Python 2.2 and updated code for 2.7. The eventual goal (for me) is getting this running on Python 2.7 and Python 3.4+. This is not Python3 compatible at the moment and won't be until I dive deeper into the core.
Some key things:
from __future__ import print_functioninkeywordraise RuntimeError, "can't parse %s" % name->raise RuntimeError("can't parse %s" % name)All the tests pass on my machine with the exception of Django and RDF which have both changed significantly since this package was last updated.
Notes: I had to do some shenanigans to get dbhash to run on my macOS machine but those tests pass.
macOS's
seddoesn't have a--versionflag. Or even a version number which is super bizarre. Those tests pass when they are forced to run.