search

rubysherpas / forem

The best Rails 3 and Rails 4 forum engine. Ever.
http://forem.herokuapp.com
MIT License
1.55k stars 423 forks source link

View templates are too "clever" #417

Open parndt opened 11 years ago

parndt commented 11 years ago

There is far too much logic in the view. Anywhere there's a conditional we can probably do better, imho. :smile:

radar commented 11 years ago

Any particular hotspots that you have in mind?

parndt commented 11 years ago

Anything with logic ;-) it's hard to reuse parts of Forem without reimplementing things. Presenter objects etc would make for a more fun time. I am addressing things such as this with my latest PRs and there is much more to come. :-)

On Tuesday, 28 May at 3:26 PM Ryan Bigg wrote:

Any particular hotspots that you have in mind?

Reply to this email directly or view it on GitHub: https://github.com/radar/forem/issues/417#issuecomment-18496167