search

rubysherpas / forem

The best Rails 3 and Rails 4 forum engine. Ever.
http://forem.herokuapp.com
MIT License
1.55k stars 422 forks source link

able to use with rails 4.2.1 too #659

Open mpakus opened 9 years ago

yan-hoose commented 9 years ago

Since there is a bug in Rails 4.2 that causes Forem to double-increment views, I don't recommend to use Forem with Rails 4.2 until that bug is fixed (https://github.com/radar/forem/issues/640).

If you are fine with that, go ahead! :smile:

radar commented 9 years ago

I am not fine with having Forem support a version of Rails with a known regression. Therefore I won't be accepting this PR until Rails 4.2.2 is released.

senych-vitalii commented 9 years ago

hey @radar Rails 4.2.2 is already released, can you accept PR? Currently I cannot use Forem without this fix because I use 4.2.1 version of Rails...

radar commented 9 years ago

Does 4.2.2 contain the specified patch or is it just security releases?

On 19 Jun 2015, at 19:43, Vitaliy Senich notifications@github.com wrote:

hey @radar Rails 4.2.2 is already released, can you accept PR?

— Reply to this email directly or view it on GitHub.

senych-vitalii commented 9 years ago

@radar it seems not... Sorry, I missed that counter is working in 4.2 version and is not working in 4.2.1.

yan-hoose commented 9 years ago

Actually counter caches are broken in all of Rails 4.2 versions. Forem Rails dependency should be

s.add_dependency 'rails', '~> 4.0', '< 4.2'

instead of

s.add_dependency 'rails', '~> 4.0', '<= 4.2'
radar commented 9 years ago

I'm fine with leaving the dependency as it is now. If people complain about the counter cache issue, we can point them to this issue.

edmondchui commented 8 years ago

The counter issue is fixed in Rails 4.2.4. Could you please update the dependency to Rails 4.2.4, 4.2.5, and above? Thanks.

sintro commented 8 years ago

The counter issue is fixed in Rails 4.2.4. Could you please update the dependency to Rails 4.2.4, 4.2.5, and above? Thanks.

Is not it already updated?