search

rubysherpas / forem

The best Rails 3 and Rails 4 forum engine. Ever.
http://forem.herokuapp.com
MIT License
1.55k stars 422 forks source link

Reduce the Number of Migration Files #660

Open TekuConcept opened 9 years ago

TekuConcept commented 9 years ago

I noticed when adding the forem engine to our website that there were a total of 32 migration files generated. I merged them into 9 individual table files and 1 user file.

TekuConcept commented 9 years ago

My bad, I stumbled upon the 'CONTRIBUTING.md' file several hours after creating this pull request. I am currently in the process of fixing those errors presented in the 'rspec spec' tests.

yan-hoose commented 9 years ago

If you are talking about the Travis CI test failures then all of them are currently caused by Forem specifying

s.add_dependency 'rails', '~> 4.0', '<= 4.2'

in the gemspec even though there is no Rails 4.2 support right now. This means that the tests are run in the context of a Rails 4.2 app and results in a lot of errors. Rails 4.2 support and all the errors have been fixed but not yet pushed to Forem since there is a bug in Rails 4.2 that prevents the push. More details here: https://github.com/radar/forem/issues/640

TekuConcept commented 9 years ago

Good to know; I will push my updates based on the contribution standards.