search

rubysherpas / paranoia

acts_as_paranoid for Rails 5, 6 and 7
Other
2.89k stars 529 forks source link

Support dependent: :destroy #508

Closed pomartel closed 3 years ago

pomartel commented 3 years ago

Fixes #507

pomartel commented 3 years ago

This is more complicated than I first thought. Counter caches and permanent deletes also need to be handled correctly. I started implementing a custom DestroyAssociationAsyncJob but now I see that the gem maintainers don't accept new features so I will close this PR for now but I would be interested in digging deeper if there is a chance this feature can be accepted.

mathieujobin commented 2 years ago

@pomartel I am definitely interesting seeing destroy_async support in paranoia

pomartel commented 2 years ago

Sorry @mathieujobin, I opted to destroy records asynchronously in my own code instead (using a background job).

mathieujobin commented 2 years ago

No problem

It sounds like a good solution