rubysherpas / paranoia

acts_as_paranoid for Rails 5, 6 and 7
Other
2.87k stars 524 forks source link

New "deletion_time" does not work with sentinel_value #530

Closed sherif-nedap closed 2 years ago

sherif-nedap commented 2 years ago

https://github.com/rubysherpas/paranoia/pull/481

if you use a sentinel_value that uses a boolean value instead of timestamp

mathieujobin commented 2 years ago

would you be able to write a test that reproduce this issue please?

sherif-nedap commented 2 years ago

@mathieujobin i have created a test for it and discovered where the issue is..

https://github.com/rubysherpas/paranoia/pull/531

sherif-nedap commented 2 years ago

https://github.com/rubysherpas/paranoia/pull/531#issuecomment-1075301151

mathieujobin commented 2 years ago

thanks for the report and the test

fix pushed in v2.5.3