search

rubysherpas / paranoia

acts_as_paranoid for Rails 5, 6 and 7
Other
2.89k stars 529 forks source link

Use paranoia_destroyed? instead of deleted? #545

Closed mlarraz closed 1 year ago

mlarraz commented 1 year ago

deleted? might be overridden by other gems (or the model itself), better to use the namespaced method internally.

mathieujobin commented 1 year ago

have you tested this in production ?

mathieujobin commented 1 year ago

test failures looks unrelated... I wonder if you are up to date? tests used to pass. are you able to look into it ?

mjobin-mdsol commented 1 year ago

just rebase or merge core in to fix the Minitest issue

mlarraz commented 1 year ago

have you tested this in production ?

Yes we have patched this in production and been running it for a few weeks.