rubyworks / crypt3

Unix Crypt 3 in Ruby
http://rubyworks.github.com/crypt3
BSD 2-Clause "Simplified" License
7 stars 3 forks source link

Mention in readme that gem facets is needed #2

Closed dentarg closed 13 years ago

dentarg commented 13 years ago

I think you should mention in the readme that you need (or was it only me?) facets as well.

Without facets gem installed:

>> require 'rubygems'
=> false
>> require 'crypt3'
LoadError: no such file to load -- facets/string/xor.rb
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require'
    from /Users/dentarg/.gem/ruby/1.8/gems/crypt3-1.1.0/lib/crypt3.rb:36
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require'
    from (irb):4

After doing gem install facets I had better luck:

>> require 'rubygems'
=> false
>> require 'crypt3'
=> true
>> Crypt3.crypt('pass')
=> "$1$qEfNSNGZ$jRUCV6eauhk5SUFDWHgv8/"
trans commented 13 years ago

Indeed you are right. Thanks for reporting this. Looks like I misconstrued crypt3's need for this extension. Apparently the String xor method isn't actually needed at all. I went ahead and removed it and released a new version.

Thanks again.

trans commented 13 years ago

Fixed as of 1.1.1/1.1.2.