search

rubyworks / facets

Ruby Facets
http://rubyworks.github.com/facets
Other
798 stars 99 forks source link

Add split_at method. #260

Closed ioquatix closed 8 years ago

ioquatix commented 8 years ago

This method is more useful for complex objects, e.g. splitting a list of User objects to find users before and after a given user. In this case you'd normally provide a block.

This is building fine but there is something wrong with 1.9.3 on travis. Perhaps it should be deprecated? e.g. build 2.x only?

Note: I closed the other PR because it was from the master branch and I couldn't change it.

trans commented 8 years ago

Looks good! Let me fix that travis issue and then I will merge.

ioquatix commented 8 years ago

@trans awesome thanks I look forward to adding facets as a dependency of https://github.com/ioquatix/utopia once this is merged + the date comparison stuff. It will be awesome to move these generic extensions into facets, it's logical and that makes me happy :D