search

rucio / probes

Common Nagios probes to monitor Rucio
Apache License 2.0
0 stars 24 forks source link

Adapt probes to rucio/rucio#5804 #108

Closed dchristidis closed 1 year ago

dchristidis commented 1 year ago

record_gauge() does not exist anymore and calls to it need to be adapted.

ericvaandering commented 1 year ago

Any objection to adding a record_gauge function to the probe_utils which matches the old signature to the new? @bari12 @dchristidis

dchristidis commented 1 year ago

After a chat with Radu, I don’t think this to be the optimal approach. The amount of boiler appears to be negligible:

from rucio.core.monitor import MetricManager
METRICS = MetricManager(prefix='…')

METRICS.gauge('…').labels(…).set(…)

The question is how to pick an appropriate naming convention. I would suggest rucio.probes at least. I’m not sure whether following it up with the probe name could also be useful.

ericvaandering commented 1 year ago

So how does this work. Looking into the code I see metrics like blah.{rse}.set_labels(rse='x'). I presume prometheus that metric will be blah with the dots stripped off and in statsd the metric name will include the "dotted" things?

So the functionality is the same as we had before but the signature is different?

ericvaandering commented 1 year ago

Partly done in https://github.com/rucio/probes/pull/110 Rest is done in https://github.com/rucio/probes/pull/113