search

rucio / probes

Common Nagios probes to monitor Rucio
Apache License 2.0
0 stars 23 forks source link

Modernize expired dids to use prom pusher #143

Open voetberg opened 1 month ago

voetberg commented 1 month ago

I'm redoing all of PR #132 with the updated sqla guidelines

voetberg commented 1 month ago

Looks good, thanks for bearing with me.

Following the contribution guide, I need approval from @/ericvaandering before I can merge.

Eric is on vacation until next week so we'll have to wait. I already talked with him about this anyways so I assume it'll just be a formality.

ericvaandering commented 1 month ago

Looks good, thanks for bearing with me. Following the contribution guide, I need approval from @/ericvaandering before I can merge.

Eric is on vacation until next week so we'll have to wait. I already talked with him about this anyways so I assume it'll just be a formality.

I assume the content-wise this is the exact same as #132 except for possibly some different SQLAlchemy grammar?

voetberg commented 1 month ago

Looks good, thanks for bearing with me. Following the contribution guide, I need approval from @/ericvaandering before I can merge.

Eric is on vacation until next week so we'll have to wait. I already talked with him about this anyways so I assume it'll just be a formality.

I assume the content-wise this is the exact same as #132 except for possibly some different SQLAlchemy grammar?

Yeah it's completely identical besides for the sql2.0 and some minor formatting/spacing/indenting

ericvaandering commented 1 week ago

I approve. Can be merged.