ruckus / quickbooks-ruby

Quickbooks Online REST API V3 - Ruby
MIT License
374 stars 302 forks source link

Add minorversion to Account service #487

Closed colmheaney closed 4 years ago

colmheaney commented 4 years ago

Some accountSubTypes are only available with minorversion 13 and higher. Creating/updating these Accounts works fine since we can pass the in the minorversion via the query option parameter.

But, when querying the QBO API for Accounts with accountSubTypes added post minorversion 13, the classification attribute in the response is nil since there is no way to specify the minorversion in the Quickbooks:: Service:: Account

Would it be possible to add the minorversion in the same way that it's added in the Quickbooks:: Service:: Item service object: https://github.com/ruckus/quickbooks-ruby/blob/4d788fbc9bf49cd849199b12a667dc3cce4c20cf/lib/quickbooks/service/item.rb#L20-L23

Happy to PR this is you think it'd be worthwhile.