ruckus / quickbooks-ruby

Quickbooks Online REST API V3 - Ruby
MIT License
374 stars 302 forks source link

Escape regex matching numbers in report parsing #511

Closed mehwoot closed 4 years ago

mehwoot commented 4 years ago

. will match anything, not just the literal character. This means that the regex that is attempting to filter only numbers will match unexpected strings, such as "T1", which matches /^.\d+$/, but does not match ^\.\d+$/ Previously when values such as "T1" appear in a report, an exception will be raised by BigDecimal because it cannot parse the value

ruckus commented 4 years ago

Thank you!