search

ruckus / quickbooks-ruby

Quickbooks Online REST API V3 - Ruby
MIT License
374 stars 302 forks source link

Feature ClassRef not supported with minor version: null, please use minor version: 41 or above #522

Closed gregdymek closed 4 years ago

gregdymek commented 4 years ago

on POST http://sandbox-quickbooks.api.intuit.com:443/v3/company/XXX/item it looks like we're not sending minor version on service item, looking at the code we only append minorversion for url_for_query shouldn't we also send it in other methods? it stopped working ~ a week ago

ruckus commented 4 years ago

Good call. For some reason I was under the impression the minorversion handling only applied to GET requests. But I now see that doesn't make much sense.

I have opened this PR with support for ensuring a minorversion query param is sent on all HTTP requests.

https://github.com/ruckus/quickbooks-ruby/pull/518

If you have a chance to take a look at the PR that would be appreciated

gregdymek commented 4 years ago

hey @ruckus, we are little blocked here, any chance you can release it soon?

ruckus commented 4 years ago

Hi @gregdymek - gotcha. Before I release the gem it would be great if you could test it. Are you in a position to give this branch a whirl:

https://github.com/ruckus/quickbooks-ruby/tree/global-minorversion

Thanks!

gregdymek commented 4 years ago

hi @ruckus - so far everything is working for us

ruckus commented 4 years ago

@gregdymek great I have just released 1.0.11

https://github.com/ruckus/quickbooks-ruby/commit/3c68b685e963195970ab67f27f34503bc1000d7b