search

ruckus / quickbooks-ruby

Quickbooks Online REST API V3 - Ruby
MIT License
374 stars 302 forks source link

Update roxml gem dependency for Ruby 2.7 support #523

Closed jacobjlevine closed 4 years ago

jacobjlevine commented 4 years ago

roxml v 4.1.0 was just released with fixes to address a deprecation warning from Ruby 2.6 and related breaking change in Ruby 2.7.

jacobjlevine commented 4 years ago

@pjrashidi, I think I saw you were the one to update the README file about this a few months ago. Any insights into what's needed for this? Is it as simple as updating the gemspec and README files?

pooriajr commented 4 years ago

@jacobjlevine Woohoo, nice catch! But actually...I don't know what is required to safely make this update without breaking things for people... I'm pretty new to ruby and contributing to open source projects like this one

ruckus commented 4 years ago

This should be resolved by #524 which was just merged in! :)

jacobjlevine commented 4 years ago

Thanks, @rmacklin for your work on this!

@ruckus thanks for your attention on this as well. What're you thinking in terms of publishing a new version of the gem?

rmacklin commented 4 years ago

1.0.10 has been released: https://rubygems.org/gems/quickbooks-ruby/versions/1.0.10