search

ruckus / quickbooks-ruby

Quickbooks Online REST API V3 - Ruby
MIT License
374 stars 302 forks source link

Faraday Versions #593

Closed jaredmoody closed 1 year ago

jaredmoody commented 1 year ago

Both Faraday 1.x and 2x are allowed dependencies, but the released code currently breaks with Faraday 1.x - one example is reported in #587.

If 2.x is not going to be required, the gem needs to be tested against and support both versions.

This PR adds Faraday 1.x to the test matrix, with the goal of revealing broken tests so they can be addressed.

jaredmoody commented 1 year ago

Disconnecting the Access token was the only failing test. The failures on ruby-head seem unrelated to this PR.

ruckus commented 1 year ago

Thanks @jaredmoody and @ashkulz . I just released 2.0.1 with this PR.