I decided to just use Faraday's alias of UploadIO since they check the version of mutlipart-post you're on and alias the constant properly. I also added >= 1.0.4 for multipart-post...since Faraday::UploadIO wasn't introduced until 1.0.2 anyways. So, I'm not sure how this was working for folks with multipart-post 1.0.0 or 1.0.1: https://github.com/ruckus/quickbooks-ruby/blob/2.0.2/lib/quickbooks/service/upload.rb#L23
ngan
commented
1 year ago
This changes all reference of the deprecated
::UploadIOforFaraday::UploadIO.multipart-post 2.2.0deprecates top-levelUploadIO: https://github.com/socketry/multipart-post/commit/cb18a32ed9522af9e4072195d0411a8281c6a061#diff-f192e4f2c6b7ce852ab54997f6dec1141f625ccd9d02a002b1a8adc39033c250I decided to just use Faraday's alias of
UploadIOsince they check the version ofmutlipart-postyou're on and alias the constant properly. I also added>= 1.0.4formultipart-post...sinceFaraday::UploadIOwasn't introduced until 1.0.2 anyways. So, I'm not sure how this was working for folks withmultipart-post 1.0.0 or 1.0.1: https://github.com/ruckus/quickbooks-ruby/blob/2.0.2/lib/quickbooks/service/upload.rb#L23