ruckus / quickbooks-ruby

Quickbooks Online REST API V3 - Ruby
MIT License
374 stars 302 forks source link

Loosen faraday-gzip to a version that can use > zlib-2.1.1 #613

Closed technicalpickles closed 1 month ago

technicalpickles commented 1 month ago

I was looking to update our app from using zlib 2.1.1 to the latest zlib-3.1.1, but bundler wasn't able to update it. I tracked down the dependency chain to:

This PR tries to loosen the dependency to >= 1.0. I'm open to other variations that would allow faraday-gzip-2 though.

kevGalway commented 1 month ago

We have the same problem so eager for solution to this too.

We are on latest version of ruby (3.3.3) meaning zlib 3.1.1 is a standard/default gem (https://stdgems.org/zlib/)

to update faraday to 2.x we need to update quickbooks-ruby to 2.x quickbooks-ruby2.x depends on faraday-gzip (~> 0.1) to faraday-gzip (~> 1.0) faraday-gzip before 2.0 depends on zlib 2.x and only starting to use zlib 3.x from version 2.0.0

@technicalpickles purposed solutions should work for us.

ruckus commented 1 month ago

Thank you @technicalpickles . Makes sense.

technicalpickles commented 1 month ago

@ruckus Thank you! Any chance of getting a release with this out as well?

ruckus commented 1 month ago

Hi @technicalpickles I just released 2.0.4 with your PR. Thanks again!!