search

ruddarr / app

A native iOS companion app for Radarr and Sonarr instances.
https://apps.apple.com/app/ruddarr/id6476240130
MIT License
117 stars 6 forks source link

Fix Notification instance switching #367

Closed Peaceout32 closed 4 weeks ago

Peaceout32 commented 1 month ago

Describe the bug Clicking on a notification doesn't take you to the movie/show page if you are not already in that instance. It works fine if you are already in the instance that has this movie/show.

To Reproduce Steps to reproduce the behavior:

  1. Be in instance 1
  2. Get a notification from a movie/show that's in instance 2
  3. See that you are now at the main page of instance 1 and not in the movie/show page in instance 2

Expected behavior Clicking on the notification should switch you to the correct instance and take you to the movie/show page

Screenshots / Video Can add if needed

Environment

Additional context N/A

tillkruss commented 1 month ago

Instance IDs would need to be added to the web hook: https://github.com/ruddarr/app/blob/develop/Ruddarr/Models/Instances/InstanceWebhook.swift#L119

tillkruss commented 4 weeks ago

The *arr payload doesn't contain enough data to determine the instance. I don't think this will ever work unless Radarr/Sonarr supply more data.

tillkruss commented 4 weeks ago

Nevermind, we can use the instanceName for this.