fix: android sample application with rudderstack.properties

[ChryssaAliferi]

Ticket

Description

In this PR, we are solving the problem that was caused in the previous merge to feat/android due to the missing property of instanceName that is now unused, but also we are improving the local.properties file setup, by creating a rudderstack.properties.sample (which needs to be replaced) and by guiding our clients to have the rudderstack.properties out of their Version Control Systems. Also, a minor refactoring change in the sample application's build.gradle.kts in order to portray a more granular error if the rudderstack.properties file is missing.

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Implementation Details

• Renaming of thelocal.properties to rudderstack.properties.sample
• Added a prompt in the rudderstack.properties.sample file for the clients to create their own version of rudderstack.properties file
• removes unused instanceName instances
• Minor refactoring change in sample applications build.gradle.kts

Checklist:

• [ ] Version upgraded (project, README, gradle, podspec etc)
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added unit tests for the code
• [x] I have made corresponding changes to the documentation

Screenshots

• Kotlin Sample application builds as normal!

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[saikumarrs]

@ChryssaAliferi, maybe we should treat this as a "chore," as the changes only pertain to the sample apps and do not affect the functionality of the SDK itself.

[ChryssaAliferi]

@ChryssaAliferi, maybe we should treat this as a "chore," as the changes only pertain to the sample apps and do not affect the functionality of the SDK itself.

It crossed my mind, however, because as project this was not buildable, I preferred the fix tag.