rudderlabs / rudder-sdk-android

Android SDK for RudderStack - the Customer Data Platform for Developers.
https://www.rudderstack.com
Other
18 stars 28 forks source link

fix: serialization uid missing issue and repository all data as callback issue #426

Closed itsdebs closed 1 month ago

itsdebs commented 2 months ago

Fixes # (issue)

  1. Provided overloaded methods for serialization thus making it faster and open to update
  2. Removed all data sent in callback thereby increasing performance.

    Type of change

    • [ ] Bug fix (non-breaking change which fixes an issue)
    • [ ] New feature (non-breaking change which adds functionality)
    • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • [ ] This change requires a documentation update

      Checklist:

    • [ ] Version upgraded (project, README, gradle, podspec etc)
    • [ ] My code follows the style guidelines of this project
    • [ ] I have performed a self-review of my own code
    • [ ] I have commented my code, particularly in hard-to-understand areas
    • [ ] I have added unit tests for the code
    • [ ] I have made corresponding changes to the documentation
ChryssaAliferi commented 1 month ago

@itsdebs Help me understand why in this PR we are implementing readObject() and writeObject()? These methods are used when we want to customize the serialization of the object or when we are having transient fields, but in our case no actual customization happens, nor any transient fields are used.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud