search

rudderlabs / rudder-sdk-js

JavaScript SDK for RudderStack - the Customer Data Platform for Developers.
https://www.rudderstack.com
Other
141 stars 82 forks source link

feat(analytics-js-integrations): onboard ga4 v2 hybrid mode #1802

Closed utsabc closed 1 month ago

utsabc commented 1 month ago

PR Description

Onboarding hybrid mode implementation for GA4 V2, this uses the existing GA4 implementation under the hood, with minor updates. The main change is that we are not going to execute the cookie migration logic if its GA4 V2

Linear task (optional)

https://linear.app/rudderstack/issue/INT-2444/%5Bfeature%5D-onboard-ga4-v2-for-hybrid-mode

Cross Browser Tests

Please confirm you have tested for the following browsers:

Sanity Suite

Security

coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (2) * main * develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 56.54%. Comparing base (7dd90a6) to head (439b056).

Files Patch % Lines
...js-integrations/src/integrations/GA4_V2/browser.js 50.00% 15 Missing and 1 partial :warning:
...mon/src/constants/integrations/GA4_V2/constants.ts 0.00% 6 Missing :warning:
...lytics-js-common/src/constants/destinationNames.ts 0.00% 3 Missing :warning:
...tics-js-common/src/v1.1/utils/integration_cname.js 0.00% 1 Missing :warning:
...cs-js-integrations/src/integrations/GA4/browser.js 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## hotfix/23.07 #1802 +/- ## ================================================ - Coverage 56.58% 56.54% -0.05% ================================================ Files 471 473 +2 Lines 16069 16114 +45 Branches 3204 3222 +18 ================================================ + Hits 9093 9111 +18 + Misses 5762 5755 -7 - Partials 1214 1248 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Cookies Utils - Legacy - NPM (ESM) 1.54 KB 1.54 KB (0%) 2 KB ✅
Cookies Utils - Legacy - NPM (CJS) 1.75 KB 1.75 KB (0%) 2 KB ✅
Cookies Utils - Legacy - NPM (UMD) 1.53 KB 1.53 KB (0%) 2 KB ✅
Cookies Utils - Modern - NPM (ESM) 1.17 KB 1.17 KB (0%) 1.5 KB ✅
Cookies Utils - Modern - NPM (CJS) 1.4 KB 1.4 KB (0%) 1.5 KB ✅
Cookies Utils - Modern - NPM (UMD) 1.16 KB 1.16 KB (0%) 1.5 KB ✅
Plugins Module Federation Mapping - Legacy - CDN 332 B 332 B (0%) 512 B ✅
Plugins - Legacy - CDN 15.74 KB 15.82 KB (+0.48% ▲) 16 KB ✅
Plugins Module Federation Mapping - Modern - CDN 331 B 331 B (0%) 512 B ✅
Plugins - Modern - CDN 7.19 KB 7.19 KB (0%) 7.5 KB ✅
Common - No bundling 15.87 KB 15.92 KB (+0.29% ▲) 16.5 KB ✅
Service Worker - Legacy - NPM (ESM) 29.43 KB 29.43 KB (0%) 30 KB ✅
Service Worker - Legacy - NPM (CJS) 29.65 KB 29.65 KB (0%) 30 KB ✅
Service Worker - Legacy - NPM (UMD) 29.42 KB 29.42 KB (0%) 30 KB ✅
Service Worker - Modern - NPM (ESM) 24.62 KB 24.62 KB (0%) 25 KB ✅
Service Worker - Modern - NPM (CJS) 24.83 KB 24.83 KB (0%) 25 KB ✅
Service Worker - Modern - NPM (UMD) 24.62 KB 24.62 KB (0%) 25 KB ✅
Core (v1.1) - NPM (ESM) 29.71 KB 29.77 KB (+0.2% ▲) 32 KB ✅
Core (v1.1) - NPM (CJS) 29.89 KB 29.98 KB (+0.28% ▲) 32 KB ✅
Core (v1.1) - NPM (UMD) 29.77 KB 29.79 KB (+0.1% ▲) 32 KB ✅
Core (Content Script - v1.1) - NPM (ESM) 29.28 KB 29.34 KB (+0.22% ▲) 30 KB ✅
Core (Content Script - v1.1) - NPM (CJS) 29.51 KB 29.55 KB (+0.15% ▲) 30 KB ✅
Core (Content Script - v1.1) - NPM (UMD) 29.39 KB 29.35 KB (-0.15% ▼) 30 KB ✅
Core - Legacy - CDN 47.37 KB 47.39 KB (+0.05% ▲) 48 KB ✅
Core - Modern - CDN 24.03 KB 24.03 KB (0%) 24.5 KB ✅
Load Snippet 724 B 724 B (0%) 1 KB ✅
Core - Legacy - NPM (ESM) 47.26 KB 47.29 KB (+0.08% ▲) 47.5 KB ✅
Core - Legacy - NPM (CJS) 47.52 KB 47.54 KB (+0.06% ▲) 48 KB ✅
Core - Legacy - NPM (UMD) 47.24 KB 47.26 KB (+0.06% ▲) 47.5 KB ✅
Core - Modern - NPM (ESM) 23.76 KB 23.76 KB (0%) 24.5 KB ✅
Core - Modern - NPM (CJS) 23.96 KB 23.96 KB (0%) 24.5 KB ✅
Core - Modern - NPM (UMD) 23.78 KB 23.78 KB (0%) 24.5 KB ✅
Core (Bundled) - Legacy - NPM (ESM) 47.26 KB 47.29 KB (+0.08% ▲) 47.5 KB ✅
Core (Bundled) - Legacy - NPM (CJS) 47.48 KB 47.62 KB (+0.28% ▲) 48 KB ✅
Core (Bundled) - Legacy - NPM (UMD) 47.24 KB 47.26 KB (+0.06% ▲) 47.5 KB ✅
Core (Bundled) - Modern - NPM (ESM) 38.54 KB 38.58 KB (+0.11% ▲) 39 KB ✅
Core (Bundled) - Modern - NPM (CJS) 38.73 KB 38.81 KB (+0.2% ▲) 39 KB ✅
Core (Bundled) - Modern - NPM (UMD) 38.56 KB 38.6 KB (+0.12% ▲) 39 KB ✅
Core (Content Script) - Legacy - NPM (ESM) 46.72 KB 46.81 KB (+0.18% ▲) 47 KB ✅
Core (Content Script) - Legacy - NPM (CJS) 46.95 KB 47.03 KB (+0.18% ▲) 47.5 KB ✅
Core (Content Script) - Legacy - NPM (UMD) 46.75 KB 46.78 KB (+0.09% ▲) 47 KB ✅
Core (Content Script) - Modern - NPM (ESM) 38.08 KB 38.03 KB (-0.12% ▼) 38.5 KB ✅
Core (Content Script) - Modern - NPM (CJS) 38.28 KB 38.3 KB (+0.07% ▲) 38.5 KB ✅
Core (Content Script) - Modern - NPM (UMD) 38.04 KB 38.07 KB (+0.09% ▲) 38.5 KB ✅
All Integrations - Legacy - CDN 92.46 KB 93.68 KB (+1.32% ▲) 95.3 KB ✅
All Integrations - Modern - CDN 87.9 KB 88.71 KB (+0.93% ▲) 91 KB ✅
sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
45.6% Coverage on New Code (required ≥ 90%)
23.9% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud