fix: alias api - Githubissues

rudderlabs / rudder-sdk-react-native

Repository for RudderStack's React Native SDK - to track your event data via RudderStack.

https://www.rudderstack.com

Other

17 stars 18 forks source link

fix: alias api #377

Closed saikumarrs closed 2 months ago

saikumarrs commented 2 months ago

Description of the change

I've fixed the declarations and implementation of the alias API.

Marked alias(previousId, newId) as deprecated.
Added the correct function declaration alias(newId, [options]) to the API.
The API was also fixed to return the promise from the bridge.
- We have to do this for all the other APIs as well later.

Misc:

Updated the sample app with all the correct usages of the alias API.
Also, added the missing package-lock.json file.

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#1]()

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud