Closed lvrach closed 3 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 91.30435%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 74.37%. Comparing base (
4226c79
) to head (3952988
). Report is 10 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
warehouse/safeguard/stop.go | 90.47% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Motivation
It has been observe in production that during shutdown postgres can get stuck on rollback, ignoring ctx cancelation:
Proposed work-around
safeguard.MustStop
ensures that when ctx is canceled the function must return within the specified time. Otherwise it will panic.Notes:
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1231/safeguard-ctx-cancellation
Security