fix: prefer event check vs config check for vdm

koladilip commented 2 weeks ago

What are the changes introduced in this PR?

Some syncs may still be in progress when migrating from FBCA to VDM v2. Currently, the transformation process prioritizes the connection configuration, which results in treating these syncs as new VDM v2 events. We are updating the preference to prioritize the "mapped to destination" flag in the event instead to address this.

What is the related Linear task?

Resolves INT-2624

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

Developer checklist

[ ] My code follows the style guidelines of this project
[ ] No breaking changes are being introduced.
[ ] All related docs linked with the PR?
[ ] All changes manually tested?
[ ] Any documentation changes needed with this change?
[ ] Is the PR limited to 10 file changes?
[ ] Is the PR limited to one linear task?
[ ] Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

[ ] Is the type of change in the PR title appropriate as per the changes?
[ ] Verified that there are no credentials or confidential data exposed with the changes.

devops-github-rudderstack commented 2 weeks ago

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3754/test-report.html

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (hotfix/24092024@10d914e). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## hotfix/24092024 #3754 +/- ## ================================================== Coverage ? 88.70% ================================================== Files ? 594 Lines ? 32417 Branches ? 7727 ================================================== Hits ? 28754 Misses ? 3372 Partials ? 291 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.