fix: payment info entered event in facebook_conversions

sanpj2292 commented 2 weeks ago

What are the changes introduced in this PR?

The payment info entered event was not making use of properties.products instead was making use of properties itself as products array while sending data to facebook_conversions destination. Through this PR, we are looking to make use of properties.products first and if properties.products is not avaialble, we would consider properties for payment info entered event.

We have done similar change for product added to wishlist event as well.

What is the related Linear task?

Resolves INT-2698

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

Developer checklist

[ ] My code follows the style guidelines of this project
[ ] No breaking changes are being introduced.
[ ] All related docs linked with the PR?
[ ] All changes manually tested?
[ ] Any documentation changes needed with this change?
[ ] Is the PR limited to 10 file changes?
[ ] Is the PR limited to one linear task?
[ ] Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

[ ] Is the type of change in the PR title appropriate as per the changes?
[ ] Verified that there are no credentials or confidential data exposed with the changes.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.92%. Comparing base (4c0c681) to head (fa7b955). Report is 5 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3762 +/- ## =========================================== + Coverage 88.89% 88.92% +0.02% =========================================== Files 600 599 -1 Lines 32658 32609 -49 Branches 7757 7747 -10 =========================================== - Hits 29032 28998 -34 - Misses 3318 3334 +16 + Partials 308 277 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.