Open will3942 opened 2 weeks ago
Thank you @will3942 for contributing this PR. Please sign the Contributor License Agreement (CLA) before merging.
I've signed the CLA but it failed to update the PR.
Thanks @will3942 for the contribution.
I confirmed. We have received your CLA submission and the Pending CLA
label has been removed from the PR.
We will go ahead with the review.
What are the changes introduced in this PR?
Bugfix, currently if you pass
unsubscribedFromEmails: false
inside ofcontext.traits
it will throw an error in IntercomCustom attribute 'unsubscribedFromEmails' does not exist
as the trait is not filtered out.This PR correctly filters out traits based on whether they are defined as opposed to whether they are truthy or not.
What is the related Linear task?
NA
Please explain the objectives of your changes below
Bugfix for Intercom destination.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
[X] My code follows the style guidelines of this project
[X] No breaking changes are being introduced.
[X] All related docs linked with the PR?
[X] All changes manually tested?
[X] Any documentation changes needed with this change?
[X] Is the PR limited to 10 file changes?
[X] Is the PR limited to one linear task?
[X] Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
[ ] Is the type of change in the PR title appropriate as per the changes?
[ ] Verified that there are no credentials or confidential data exposed with the changes.