rudderlabs / rudder-transformer

Open-source, warehouse-first Customer Data Pipeline and Segment-alternative. Collects and routes clickstream data and builds your customer data lake on your data warehouse.
https://www.rudderstack.com
Other
79 stars 110 forks source link

Should filter out falsey reserved attributes from Intercom destination #3767

Open will3942 opened 2 weeks ago

will3942 commented 2 weeks ago

What are the changes introduced in this PR?

Bugfix, currently if you pass unsubscribedFromEmails: false inside of context.traits it will throw an error in Intercom Custom attribute 'unsubscribedFromEmails' does not exist as the trait is not filtered out.

This PR correctly filters out traits based on whether they are defined as opposed to whether they are truthy or not.

What is the related Linear task?

NA

Please explain the objectives of your changes below

Bugfix for Intercom destination.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

Reviewer checklist

contributor-support[bot] commented 2 weeks ago

Thank you @will3942 for contributing this PR. Please sign the Contributor License Agreement (CLA) before merging.

will3942 commented 2 weeks ago

I've signed the CLA but it failed to update the PR.

Screenshot 2024-09-27 at 16 42 30

gitcommitshow commented 1 week ago

Thanks @will3942 for the contribution. I confirmed. We have received your CLA submission and the Pending CLA label has been removed from the PR. We will go ahead with the review.