fix: salesforce v2 refactor

shrouti1507 commented 1 week ago

What are the changes introduced in this PR?

salesforceResponseHandler to re-visit using switch case instead of multiple if-else statements

To have single logic of to infer from event for OAUTH or LEGACY implementation - https://github.com/rudderlabs/rudder-transformer/pull/2873#discussion_r1415313844

What is the related Linear task?

Resolves INT-1129

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

Developer checklist

[ ] My code follows the style guidelines of this project
[ ] No breaking changes are being introduced.
[ ] All related docs linked with the PR?
[ ] All changes manually tested?
[ ] Any documentation changes needed with this change?
[ ] Is the PR limited to 10 file changes?
[ ] Is the PR limited to one linear task?
[ ] Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

[ ] Is the type of change in the PR title appropriate as per the changes?
[ ] Verified that there are no credentials or confidential data exposed with the changes.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (4c0c681) to head (1565e3a). Report is 13 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/v0/destinations/salesforce/utils.js	82.22%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3773 +/- ## =========================================== + Coverage 88.89% 88.93% +0.03% =========================================== Files 600 599 -1 Lines 32658 32598 -60 Branches 7757 7748 -9 =========================================== - Hits 29032 28991 -41 - Misses 3318 3330 +12 + Partials 308 277 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.