rudderlabs / rudder-transformer

Open-source, warehouse-first Customer Data Pipeline and Segment-alternative. Collects and routes clickstream data and builds your customer data lake on your data warehouse.
https://www.rudderstack.com
Other
79 stars 110 forks source link

fix: webhook proc workflow object assign bug #3775

Closed koladilip closed 1 week ago

koladilip commented 1 week ago

What are the changes introduced in this PR?

Incorrect use of javascript Object.assign, Object.assign(...[]) leads to "can't convert undefined to object"

What is the related Linear task?

Resolves INT-2739

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

Reviewer checklist

devops-github-rudderstack commented 1 week ago

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3775/test-report.html

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.94%. Comparing base (4c0c681) to head (cf539ef). Report is 14 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3775 +/- ## =========================================== + Coverage 88.89% 88.94% +0.04% =========================================== Files 600 599 -1 Lines 32658 32574 -84 Branches 7757 7741 -16 =========================================== - Hits 29032 28972 -60 + Misses 3318 3295 -23 + Partials 308 307 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sanpj2292 commented 1 week ago

Can we add a test-case for this ?

koladilip commented 1 week ago

Can we add a test-case for this ?

sure

koladilip commented 1 week ago

added test case

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
12 New issues
1 Accepted issue

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud