add wait-for condition for telegraf

Thrinadh-Kumpatla commented 2 years ago

Making sure telegraf comes up before rudder server

Currently there is no wait-for condition on telegraf. This causes rudder server to spin up before telegraf because of which metrics are lost until and unless the rudderserver is restarted. Fixing this issue by adding wait for condition when telegraf sidecar is enabled..

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#1]()

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

saurav-malani commented 2 years ago

I tried testing this change:

To test if rudder-server actually waits until telegraf sidecar is ready or not. I simply made this change: telegraf_sidecar: enabled: false with the expectation that telegraf should never come up & since this PR makes rudder-server wait for telegraf to come up. It should also never come up. But, this change throws following error: Error: INSTALLATION FAILED: template: rudderstack/templates/statefulset.yaml:112:81: executing "rudderstack/templates/statefulset.yaml" at <include "statsd.enabled" .>: error calling include: template: rudderstack/templates/_helpers.tpl:108:9: executing "statsd.enabled" at <.Values.telegraf.enabled>: nil pointer evaluating interface {}.enabled

saurav-malani commented 2 years ago

I tested the change, it seems to be working fine. Previous error is fixed. Also, wait-for condition seems to be working fine.

rudderlabs / rudderstack-helm