add ingress class - Githubissues

rudderlabs / rudderstack-helm

Open-source, warehouse-first Customer Data Pipeline and Segment-alternative. Collects and routes clickstream data and builds your customer data lake on your data warehouse.

MIT License

62 stars 48 forks source link

add ingress class #55

Open husseinferas opened 2 years ago

husseinferas commented 2 years ago

Description of the change

Description here

Add the option to specify the ingress class (important for Nginx ingress controller, and if you have multiple ingress controller running in the cluster)

Type of change

[X] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

[X] Lint rules pass locally
[X] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[X] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

gitcommitshow commented 1 month ago

Thank you for your contribution @husseinferas , please sign this CLA so the team can go ahead with the review.